Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'log' calls fail in the java client library #1024

Open
bcb37 opened this issue Sep 21, 2023 · 1 comment
Open

'log' calls fail in the java client library #1024

bcb37 opened this issue Sep 21, 2023 · 1 comment
Assignees
Labels
bug Something isn't working metrics priority: low Low priority issue

Comments

@bcb37
Copy link
Collaborator

bcb37 commented Sep 21, 2023

The shape of response data changed from version "zero" to v1.

The log response as of v1 may have had an array added by mistake, as there are single-element arrays (example below).
We should either change the client to handle the new shape or fix the oddity in response data introduced in v1.

[
    {
        "0": {
            "createdAt": "2023-09-21T20:24:20.757Z",
            "updatedAt": "2023-09-21T20:39:07.795Z",
            "versionNumber": 5,
            "id": 1018,
            "uniquifier": "1",
            "timeStamp": "1970-01-01T00:00:00.000Z",
            "data": {
                "totalTimeSeconds": 10
            },
            "userId": "boof"
        }
    },
    {
        "0": {
            "createdAt": "2023-09-21T20:24:20.757Z",
            "updatedAt": "2023-09-21T20:39:07.799Z",
            "versionNumber": 6,
            "id": 1018,
            "uniquifier": "1",
            "timeStamp": "1970-01-01T00:00:00.000Z",
            "data": {
                "totalTimeSeconds": 20
            },
            "userId": "boof"
        }
    }
]
@bcb37 bcb37 added the bug Something isn't working label Sep 21, 2023
@amurphy-cl
Copy link
Collaborator

Resolution: change response to 200, don't send the data object, change client so it doesn't expect the object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics priority: low Low priority issue
Projects
Status: Refined ToDo
Development

No branches or pull requests

2 participants