From b409ae388b206ac5a79ff8a7d473b8630bce3c52 Mon Sep 17 00:00:00 2001 From: Zack Lee <90279765+zackcl@users.noreply.github.com> Date: Mon, 26 Aug 2024 21:20:16 +0900 Subject: [PATCH] Remove View Logs Link (#1857) --- ...lag-overview-details-section-card.component.html | 2 -- ...-flag-overview-details-section-card.component.ts | 5 ----- .../common-section-card-title-header.component.html | 3 --- .../common-section-card-title-header.component.ts | 13 ------------- 4 files changed, 23 deletions(-) diff --git a/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.html b/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.html index 8dfd79440b..c311d24b90 100644 --- a/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.html +++ b/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.html @@ -5,10 +5,8 @@ [title]="flag.name" [createdAt]="flag.createdAt" [updatedAt]="flag.updatedAt" - [showViewLogs]="true" [chipClass]="flag.status" [showWarning]="shouldShowWarning$ | async" - (viewLogs)="viewLogsClicked($event)" > diff --git a/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.ts b/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.ts index 8d75d3e1ea..3735307c0c 100644 --- a/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.ts +++ b/frontend/projects/upgrade/src/app/features/dashboard/feature-flags/pages/feature-flag-details-page/feature-flag-details-page-content/feature-flag-overview-details-section-card/feature-flag-overview-details-section-card.component.ts @@ -72,11 +72,6 @@ export class FeatureFlagOverviewDetailsSectionCardComponent implements OnInit, O return FILTER_MODE; } - viewLogsClicked(event) { - console.log('viewLogs Clicked'); - console.log(event); - } - onSlideToggleChange(event: MatSlideToggleChange, flag: FeatureFlag) { const slideToggleEvent = event.source; const newStatus = slideToggleEvent.checked ? FEATURE_FLAG_STATUS.ENABLED : FEATURE_FLAG_STATUS.DISABLED; diff --git a/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.html b/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.html index c74820c054..88b0aab77b 100644 --- a/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.html +++ b/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.html @@ -23,8 +23,5 @@
{{ ('feature-flags.details-updated-at.text' | translate) + (updatedAt | formatDate: 'short date') + '.' }} - - View logs -

diff --git a/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.ts b/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.ts index 90386f7de0..83ae1225a0 100644 --- a/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.ts +++ b/frontend/projects/upgrade/src/app/shared-standalone-component-lib/components/common-section-card-title-header/common-section-card-title-header.component.ts @@ -11,11 +11,8 @@ import { SharedModule } from '../../../shared/shared.module'; * - `title`: The title of the section card. * - `tableRowCount`: The count of rows in the table. If it's falsy, nothing will be displayed. If it's greater than 1, the count will be displayed in parentheses. * - `subtitle`: The subtitle of the section card. - * - `showViewLogs`: A boolean that determines whether to show the "View Logs" text anchor tag. * - `chipClass`: The class for the status chip. For example, `STATUS_INDICATOR_CHIP_TYPE.ENROLLMENT_COMPLETE`. * - * The component emits a `viewLogs` event when the "View Logs" text is clicked. This event can be used to notify a parent component. - * * Example usage: * * ```html @@ -23,10 +20,8 @@ import { SharedModule } from '../../../shared/shared.module'; * [title]="title" * [tableRowCount]="tableRowCount" * [subtitle]="subtitle" - * [showViewLogs]="true" * [chipClass]="STATUS_INDICATOR_CHIP_TYPE.ENROLLMENT_COMPLETE" * [showWarning]="false" - * (viewLogs)="viewLogsClicked($event)" * > * ``` */ @@ -47,12 +42,4 @@ export class CommonSectionCardTitleHeaderComponent { @Input() updatedAt?: string; @Input() chipClass?: STATUS_INDICATOR_CHIP_TYPE; @Input() showWarning?: boolean; - @Input() showViewLogs?: boolean; - @Output() viewLogs = new EventEmitter<{ clicked: boolean }>(); - - viewLogsClicked(): void { - this.viewLogs.emit({ - clicked: true, - }); - } }