Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: add prettier #23

Open
saihaj opened this issue Sep 24, 2020 · 0 comments
Open

frontend: add prettier #23

saihaj opened this issue Sep 24, 2020 · 0 comments
Labels
Effort: 1 pts 1/2-3 hours Scope: Frontend Status: To Do Can and should be resolved Type: DX Helps with developer experience

Comments

@saihaj
Copy link
Member

saihaj commented Sep 24, 2020

I removed it here 05cd387 . It would be great if we can get prettier working for non .js files because for .js files we have eslint working and it does format things.

Issue is eslint and prettier conflict on somethings, solution that I have seen is to get prettier format first and then run eslint on top so the conflict is gone. It should work well with vscode and not take too many resources since I like to run it on save each time.
@saihaj saihaj added Effort: 1 pts 1/2-3 hours Scope: Frontend Status: To Do Can and should be resolved Type: DX Helps with developer experience labels Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Effort: 1 pts 1/2-3 hours Scope: Frontend Status: To Do Can and should be resolved Type: DX Helps with developer experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saihaj