Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto recompiles the CSS doesn't work on DartSASS version 1.51.0 #26

Closed
andyduong1920 opened this issue May 10, 2022 · 2 comments
Closed

Comments

@andyduong1920
Copy link

Hi, thanks for this library, it helps to integrate DartSASS to Phoenix much easy 💜

Issue

I'm noticed that the auto recompiles the CSS doesn't work on the DartSASS 1.51.0, it also happens on 1.50.0 and 1.50.1

That feature is working well on 1.49.11 FYI.

As I have checked on the DartSASS release changelogs, could it be related to sass/dart-sass#1411 🤔

Step to reproduce

1/ Generate a new Phoenix 1.6.x project
2/ Add DartSASS following the README
3/ Tested with the 1.49.11 version by adjusting the app.css, the new CSS should be written in priv folder and the browser is reloaded
4/ Change the version to 1.50.0 or 1.51.0, adjust the app.css the output CSS file in priv folder didn't update.

Screencast

@mcrumm
Copy link
Member

mcrumm commented May 10, 2022

Hi @andyduong1920– unfortunately you are correct. There's a bug in 1.50+ that causes sass with --watch to exit immediately if opened by another program. I have an in-progress fix but it's not quite ready to merge. You can follow progress on the other PR:

@mcrumm
Copy link
Member

mcrumm commented Aug 26, 2022

The vendor package has moved ahead several versions and we have updated our default version past the broken 1.50 release, so this should be less of an issue now :)

@mcrumm mcrumm closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants