Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined daily data type availability checkers should use the data collection settings. #366

Open
greinard opened this issue Nov 27, 2024 · 1 comment

Comments

@greinard
Copy link
Collaborator

Currently, most/all combined daily data type availability checkers are not looking at the data collection settings to see if a given data source (such as Garmin) is enabled for the project. This can result in a bunch of server side errors being logged even while under normal operating conditions.

For example, if you use a DailyDataChart with "combined steps", but don't have Garmin enabled for your project, because you are only interested in Apple Health and Fitbit step data, then you will cause errors to be logged every time it loads and the Garmin availability check runs.

I think the non-combined availability checkers are probably okay as is. They could check the data collection settings as well, but I think it is less of an issue, because in the case of device specific data types, you probably wouldn't ever select them unless you also have them enabled for your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@greinard and others