Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face Value Input Guardrails #358

Open
lynnfaraday opened this issue Nov 14, 2024 · 0 comments
Open

Face Value Input Guardrails #358

lynnfaraday opened this issue Nov 14, 2024 · 0 comments

Comments

@lynnfaraday
Copy link
Contributor

In the Face component, the faceValue property uses number type, but there are no guardrails on the value. You can end up with a broken image:

image

I wonder if it would be better to make this an enum to reflect the fixed list of possible values? Or at least handle the error case more gracefully so it doesn't result in a broken image icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant