Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Download shows as 0 height div on native #273

Open
chrisnowak opened this issue Jun 28, 2024 · 0 comments
Open

App Download shows as 0 height div on native #273

chrisnowak opened this issue Jun 28, 2024 · 0 comments

Comments

@chrisnowak
Copy link
Contributor

chrisnowak commented Jun 28, 2024

In MyDataHelpsUI, because cards automatically disappear when their contents disappear, it's important that any components that should be hidden don't just render as an empty div

App Download currently appears to be doing that:
https://github.com/CareEvolution/MyDataHelpsUI/blob/main/src/components/container/AppDownload/AppDownload.tsx#L43-L44

This results in an extra space in the UI when you're on native

I think we just need to stick the "PlatformSpecificContent" on the outside here or something...but not sure if that would quite work with view builder with the innerRef being attached to the child. So maybe this just needs to do the platform check itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant