Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sources without leaving the website #26

Open
Betree opened this issue Oct 27, 2018 · 1 comment · May be fixed by CaptainFact/captain-fact-frontend#765
Open

Show sources without leaving the website #26

Betree opened this issue Oct 27, 2018 · 1 comment · May be fixed by CaptainFact/captain-fact-frontend#765
Assignees
@wdestin
Labels
blocked This issue depends on something else to be completed complexity > medium Consequent tasks, usually done in one to three days of work design Everything related to design, UX and UI feature New features frontend Everything for https://github.com/CaptainFact/captain-fact-frontend

Comments

@Betree
Copy link
Member

Betree commented Oct 27, 2018

Preview
@Betree Betree transferred this issue from CaptainFact/captain-fact-frontend Dec 9, 2018
@Betree Betree added feature New features frontend Everything for https://github.com/CaptainFact/captain-fact-frontend complexity > medium Consequent tasks, usually done in one to three days of work Up For Grabs Want to help? This task is a good one! design Everything related to design, UX and UI labels Dec 9, 2018
@wdestin wdestin linked a pull request Feb 23, 2021 that will close this issue
Open
@Betree Betree added blocked This issue depends on something else to be completed and removed Up For Grabs Want to help? This task is a good one! labels Apr 14, 2021
@Betree
Copy link
Member Author

Betree commented Apr 14, 2021

@wdestin implemented a great proof of concept for this feature in CaptainFact/captain-fact-frontend#765. While the prototype worked well for simple cases, dealing with the x-frame-options header and dead links ended up being pretty challenging. The delay introduced pre-fetching the source was actually going to degrade the UX instead of improving it.

If we want to take another look at it, we should have clever specs that take these issues into account. That might however not be a priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdestin wdestin

Labels
blocked This issue depends on something else to be completed complexity > medium Consequent tasks, usually done in one to three days of work design Everything related to design, UX and UI feature New features frontend Everything for https://github.com/CaptainFact/captain-fact-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added iframe for statement's source CaptainFact/captain-fact-frontend
2 participants
@Betree @wdestin