Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ESP32 S2 support target hw: lolin_S2_mini #37

Open
helicocrasher opened this issue Dec 29, 2023 · 8 comments
Open

Adding ESP32 S2 support target hw: lolin_S2_mini #37

helicocrasher opened this issue Dec 29, 2023 · 8 comments

Comments

@helicocrasher
Copy link

helicocrasher commented Dec 29, 2023

@CapnBry
Thanks for that code.

I managed to get the CRSF link running on the wemos LolinS2_mini.
The only challenge was to feed the used serial port in numbers to CRSR.begin() function, as on the ESP32 S2 they are not fixed.
Seen a lot of beauty in the code ... CRSF serial telemetry, I learned a lot.
Now merging some ESP HW PWM code to it.

@helicocrasher
Copy link
Author

ESP32 HW PWM now also working. 8 Channels on ESP32 S2

@robhaswell
Copy link

ESP32 HW PWM now also working. 8 Channels on ESP32 S2

Where is the code for this, perhaps you could create a PR? I'm interested in running this on an ESP32-C3.

@CapnBry
Copy link
Owner

CapnBry commented Mar 20, 2024

Where is the code for this, perhaps you could create a PR? I'm interested in running this on an ESP32-C3.

You can just steal the code from ExpressLRS, which supports ESP32-S3 and the C3 has the same peripherals. I think ELRS might support the C3 directly as well as I know that's what everything is going to be shifting to,

@robhaswell
Copy link

Thanks, I'll take a look. My ulterior motive is to submit a PR to this project which adds VTX admin, VTX arming, and potentially a very limited implementation of voltage OSD. The goal being to be able to use this in a fixed wing without buying a full flight controller. How would you feel about those PRs?

@CapnBry
Copy link
Owner

CapnBry commented Mar 20, 2024

How would you feel about those PRs?

I don't really want them 😅 I don't want to maintain this project considering ExpressLRS supports PWM output itself now so this project is obsolete.

@robhaswell
Copy link

How would you feel about those PRs?

I don't really want them 😅 I don't want to maintain this project considering ExpressLRS supports PWM output itself now so this project is obsolete.

I get that lol, problem is that ExpressLRS doesn't want to add VTX admin, but also a user might not want to buy a PWM-capable ELRS receiver and might find adding a $2 ESP devkit to be more attractive. The main motivation is not being able to get VTX admin in ELRS though.

I get it though, I'll create a fork if I ever get round to this.

@CapnBry
Copy link
Owner

CapnBry commented Mar 20, 2024

If you wait long enough I bet ELRS will add smartaudio output. The receiver code is becoming more and more full of supporting everything a flight controller does so I think it is just a matter of time that everyone agrees SA support is worth it.

@robhaswell
Copy link

Good to know! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants