Bacon fails on a workspace with inter-member dependencies on Windows

[jDomantas]

Reproduction steps:

1. Create a workspace manifest ./Cargo.toml:

   [workspace]
   members = [
       "crate-a",
       "crate-b",
   ]

2. Create two member crates:

   cargo new --lib crate-a
   cargo new --lib crate-b
   

3. Make crate-b depend on crate-a (in ./crate-b/Cargo.toml):

   [package]
   name = "crate-b"
   version = "0.1.0"
   edition = "2018"
   
   [dependencies]
   crate-a = { path = "../crate-a" }

4. Run bacon in workspace root, or in either of the crate directories. It fails with message:

   Error: `cargo metadata` exited with an error: error: package collision in the lockfile: packages crate-a v0.1.0 (... dir1 ...) and crate-a v0.1.0 (... dir2 ...) are different, but only one can be written to lockfile unambiguously

Meanwhile cargo metadata and cargo check work correctly when ran in any of those 3 directories.

OS: Windows 10
cargo --version: cargo 1.54.0 (5ae8d74b3 2021-06-22)
bacon --version: bacon 1.2.3

[Stargateur]

I got the same

[jDomantas]

This seems to be related: rust-lang/cargo#6198

Checked on my machine and the metadata command invoked is

cargo metadata --format-version 1 --manifest-path \\?\C:\Users\<stuff...>\bacon-repro\Cargo.toml

which fails because in the end it does not normalize "bacon-repro/crate-b/../crate-a" to "bacon-repro/crate-a". If I manually invoke metadata with --manifest-path ./Cargo.toml then it works.

[jDomantas]

More investigating: it works for me if I remove this canonicalize call. I'm not sure when it is needed - I suppose it changes what Cargo.toml would be resolved in presence of symlinks, but I don't know if that matches other rust tools. I checked what rust-analyzer is doing and it seems that it just uses non-normalized paths. So maybe we can just remove that call?

I guess another option would be to use cargo metadata itself for resolving this, as it also has the logic to find a Cargo.toml somewhere in parent chain. I think you can run it in the directory given to bacon and it will tell you either a package or a workspace it resolved.

[Canop]

I'm not answering because at work today but I'm following the investigation with interest.

[Canop]

I confirm there doesn't seem to be any problem on linux.