Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Some translations are missing #357

Closed
yasmanets opened this issue Apr 22, 2022 · 2 comments · Fixed by #358
Closed

[BUG] - Some translations are missing #357

yasmanets opened this issue Apr 22, 2022 · 2 comments · Fixed by #358

Comments

@yasmanets
Copy link
Contributor

yasmanets commented Apr 22, 2022 •
edited
Loading

  • Lib Version [4.2.1]

Describe the bug
When the source selector is displayed, the texts are always in English.

To Reproduce
Steps to reproduce the behavior:

  • Displays the source picker dialog

Expected behavior
The text must appear in the language of the device.

Media
Screenshot

Smartphone (please complete the following information):

  • Device: Xiaomi Redmi 9A
  • OS: Android 10

Additional context
Add any other context about the problem here.
@yasmanets yasmanets added the bug label Apr 22, 2022
@Canato
Copy link
Member

Canato commented Apr 22, 2022

@yasmanets thanks for raising this. Please open a PR with the translations so we can add ^^

@yasmanets
Copy link
Contributor Author

Thanks @Canato !!

@yasmanets yasmanets mentioned this issue Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Translation of "Camera" and "Gallery" added in some languages yasmanets/Android-Image-Cropper
2 participants
@Canato @yasmanets