Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FTorch REQUIRED in the examples #133

Open
jatkinson1000 opened this issue Jun 5, 2024 · 1 comment · May be fixed by #134
Open

Make FTorch REQUIRED in the examples #133

jatkinson1000 opened this issue Jun 5, 2024 · 1 comment · May be fixed by #134
Assignees
@jatkinson1000
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@jatkinson1000
Copy link
Member

It came up in #124 that some linking could pass undetected for the examples as CMake does not currently 'REQUIRE' FTorch.

This could lead to linking issues later on at link or runtime that should be detected earlier when building.

We should update the examples (which are then pulled into the tests) and the online coupling guidance.
@jatkinson1000 jatkinson1000 added bug Something isn't working documentation Improvements or additions to documentation labels Jun 5, 2024
@jatkinson1000 jatkinson1000 self-assigned this Jun 5, 2024
@jatkinson1000 jatkinson1000 linked a pull request Jun 5, 2024 that will close this issue
Open
@jatkinson1000
Copy link
Member Author

Discussion with @jwallwork23 we think this would require making the building of tests a separate step from building of the library, but doing so would not be the end of the world.

This is not a priority, however, so we can stall this for now.

jwallwork23 added a commit that referenced this issue Nov 15, 2024
@jwallwork23
Drop 'FTorch REQUIRED' for unit test for now (see #133)
5863cba
jwallwork23 added a commit that referenced this issue Nov 25, 2024
@jwallwork23
Drop 'FTorch REQUIRED' for unit test for now (see #133)
5689605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatkinson1000 jatkinson1000

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require ftorch when coupling Cambridge-ICCS/FTorch
1 participant
@jatkinson1000