Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tdp_core's d3 #40

Closed
wants to merge 3 commits into from
Closed

Use tdp_core's d3 #40

wants to merge 3 commits into from

Conversation

keckelt
Copy link
Member

@keckelt keckelt commented Jul 21, 2022 •
edited
Loading

Wait for datavisyn/tdp_core#737 before merging

  • Remove dependencies to d3 (d3-select, d3-array, d3-transition, d3-format)
  • Add dependency to tdp_core

d3v3 is used once in the Compare task to pass a d3v3 Selection to TourDino

Requirements:

  • generator v11
  • mp/add_d3v7 branch of tdp_core
  • thinkh/d3_changes branches of TourDino and tdp_public

keckelt added 2 commits July 21, 2022 09:58
@keckelt
use d3v7 and d3v3 imports
e7fd3db 
remove depenencies to d3
add dependency to tdp_core
@keckelt
remove console log
0f01c7d
@keckelt keckelt requested a review from thinkh July 21, 2022 08:04
@keckelt keckelt self-assigned this Jul 21, 2022
@keckelt keckelt marked this pull request as ready for review July 22, 2022 15:34
PatrickAdelberger
PatrickAdelberger previously approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@PatrickAdelberger PatrickAdelberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay 👍

@PatrickAdelberger PatrickAdelberger mentioned this pull request Sep 8, 2022
Merged
@PatrickAdelberger
Copy link
Member

Resolved the merge conflicts with additional PR #45

@thinkh thinkh deleted the d3_changes branch August 10, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickAdelberger PatrickAdelberger PatrickAdelberger left review comments

@thinkh thinkh Awaiting requested review from thinkh

Assignees

@keckelt keckelt

Labels
priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keckelt @PatrickAdelberger