Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-release jar remapping support #14

Open
zml2008 opened this issue Feb 1, 2021 · 0 comments · Fixed by #18
Open

Multi-release jar remapping support #14

zml2008 opened this issue Feb 1, 2021 · 0 comments · Fixed by #18
Labels
bug Something isn't working enhancement New feature or request

Comments

@zml2008
Copy link
Contributor

zml2008 commented Feb 1, 2021

Currently, JarEntryRemappingTransformer uses the full path of class files to map their names. This works fine for normal jars where the class name is relative to the jar root, but does not work for multi-release jars where the class name is relative to the META-INF/versions/<n>/ directory.

The actual fix for this should be fairly straightforward, but for other API users it would be nice to integrate some of that handling into the JarClassEntry API (exposing whether a class is a multi-release variant, and a way to get/set the class name no matter how it is located).

@jamierocks jamierocks added bug Something isn't working enhancement New feature or request labels Feb 1, 2021
@jamierocks jamierocks linked a pull request Aug 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants