Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User model should have "full name" not "first name, last name" #98

Closed
ian-ross opened this issue Mar 17, 2016 · 3 comments
Closed

User model should have "full name" not "first name, last name" #98

ian-ross opened this issue Mar 17, 2016 · 3 comments
Labels
Milestone

Comments

@ian-ross
Copy link
Contributor

The default Django user model has first_name and last_name fields, which is bad for internationalisation -- bad enough that I'd consider this a bug.

We're already using a custom user model, so we should update this to use a full_name field instead. That's a more substantial change from the defaults than our current custom user model, but the changes are mostly mechanical and really just a matter of copying the AbstractUser base class from django.contrib.auth.models, changing the fields it has and changing our user model to derive from it (or just folding the new "abstract user" definition into our user model.

These changes then need to propagate through the API and to the front end as well, obviously.

@ian-ross ian-ross added the bug label Mar 17, 2016
@ian-ross ian-ross added this to the Version 0.1 milestone Mar 17, 2016
@ian-ross ian-ross assigned linzjax and unassigned seav Apr 29, 2016
@ian-ross ian-ross closed this as completed May 5, 2016
@Avin-Techv
Copy link

Avin-Techv commented Mar 8, 2019

Is there an alternate solution to getting "full name"?

@oliverroick
Copy link
Member

Hi @Avin-Techv, you can have a look at our custom User class to learn how we solved this.

@singitaN
Copy link

singitaN commented Mar 3, 2021

Hi @oliverroick I'm applying the same code but I get an OperationalError at /admin with a no such column: core_user.full_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants