As a superuser, activating a user fails

[oliverroick]

Steps to reproduce the error

On the development VM, with fixtures loaded:

1. Login as a superuser (either iross or oroick)
2. Go to the user view (it's the link in the menu)
3. Active testuser10.
4. Logout
5. Login as testuser10

Actual behavior

The account of testuser10 is still inactive.

Expected behavior

The account of testuser10 is active.

The culprit

organization.views.default.UserActivation sets the field is_active to the correct state; in the example above it is True. testuser10's email verification period has expired; when they try to login, the account will be deactivated immediately.

Should organization.views.default.UserActivation also set email_verified to True (i.e. manually confirming the email address) when activating the account?

[dpalomino]

Thanks @oliverroick. IMO yes, it should also verify the account...

[seav]

Can we actually say that the email is verified if it was never verified? The email could be wrong, for one thing. Maybe activating the user means just resetting the expiration period.

[oliverroick]

I think, @seav is right. The user receives an email to confirm their email address, which will activate the account.

The behaviour described above is correct, I think we can close this.

[amplifi]

Does this cover the case where the user doesn't have an email address?

[wonderchook]

Not sure that makes sense. We shouldn't be assuming people should be able to get emails. Long term I think the issue is we need to make an Architecture Design Proposal about how we deal with users without email addresses.

[dpalomino]

Apart from the user without mail address registered (that's being discussed separately), this is now working as expected, so we can close the issue.