Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project overview stats needs CSS adjustment for large numbers #872

Closed
seav opened this issue Oct 27, 2016 · 5 comments
Closed

Project overview stats needs CSS adjustment for large numbers #872

seav opened this issue Oct 27, 2016 · 5 comments

Comments

@seav
Copy link
Contributor

seav commented Oct 27, 2016

Steps to reproduce the error

Go to the project overview page of a project that has thousands of locations, parties, or resources.

Actual behavior

Stats number overflows its container. (See screenshot below.)

Expected behavior

Stats number does not overflow its container.

screen shot 2016-10-27 at 17 05 25

@dpalomino
Copy link

Thanks @seav, good catch!

If this is not difficult, it'd be nice to have it solved more or less soon (maybe next sprint?). We are expecting to have this numbers soon.

@clash99
Copy link
Contributor

clash99 commented Oct 27, 2016

This is a great problem :)

I can include this sprint with a few other css changes.

@clash99 clash99 self-assigned this Oct 27, 2016
@clash99
Copy link
Contributor

clash99 commented Nov 1, 2016

Made responsive font adjustments for 6 figure numbers.

screenshot 2016-11-01 15 32 08

screenshot 2016-11-01 15 33 55

screenshot 2016-11-01 15 36 21

screenshot 2016-11-01 15 38 20

screenshot 2016-11-01 15 39 52

@dpalomino
Copy link

Looks great, thanks @clash99!

@seav
Copy link
Contributor Author

seav commented Nov 9, 2016

Things are much better now, but we still have some overlaps. Not sure if this should really be fixed at all or in the (far?) future.

When the viewport width is at exactly 992px, the font size becomes larger compared to at 993px. (At 991px, the layout changes to the medium size layout.) See screenshot below.

screen shot 2016-11-09 at 17 18 08

At 993px to around 1020px, the numbers overlap their borders:

screen shot 2016-11-09 at 17 26 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants