Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archived project detail page is still accessible #783

Closed
oliverroick opened this issue Oct 4, 2016 · 3 comments
Closed

Archived project detail page is still accessible #783

oliverroick opened this issue Oct 4, 2016 · 3 comments

Comments

@oliverroick
Copy link
Member

Steps to reproduce the error

  • Create a new project
  • Archive the project
  • You end up on the project detail page; the project is flagged as archived
  • Go to the organization's project list; the project is not visible there

Actual behavior

Not sure if it's really a bug but there are some inconsistencies. As a project manager I can still access the project detail page but it's not visible in the project list. Also I can't access any of the edit pages (edit permissions, details, etc); I get Permission Denied there.

Expected behavior

Not sure, it should be consistent. If I'm can access an archived project, which makes sense a project manager, then it should be in the list of projects. And I should be able to access the edit pages; for instance, to unarchive the project

@linzjax
Copy link
Contributor

linzjax commented Oct 4, 2016

Precursor: I made a lot of this permission stuff up as I went along, so any decisions made I can easily be convinced otherwise.

You can still access archived projects by filtering the active/archived/all select button next to the search box on a project list (if you don't see this, it's either because my most recent changes haven't been pushed to staging, or something's wrong).

I thought that org admin should still be able to view archived orgs/projs because they should be able to unarchive them, but do nothing else. But if you archive a project, should you be redirected to a project list? Is it too hard to find it again if you do this on accident?

You can still unarchive the project, even if you can't select project edit.

@linzjax
Copy link
Contributor

linzjax commented Oct 4, 2016

(this fix has already been pulled into master, but) If you select view 100 projects at the bottom of the table so that the project list displayed is longer, the select button might appear if it's missing.

@oliverroick
Copy link
Member Author

Ah I see, I hadn't seen the filter dropdown. This all makes sense now. But then we should hide the edit page links on archived projects. Closing this and opening a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants