Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change a org members project permissions. #779

Closed
linzjax opened this issue Oct 4, 2016 · 3 comments
Closed

Can't change a org members project permissions. #779

linzjax opened this issue Oct 4, 2016 · 3 comments

Comments

@linzjax
Copy link
Contributor

linzjax commented Oct 4, 2016

Steps to reproduce the error

Go to your organizations member page
Click on a member
Change their project permissions to anything other than what it is
Save changes
Click on member again
See change not saved.

Actual behavior

Their permissions remains unchanged.

Expected behavior

It would change to whatever I had selected

@linzjax linzjax changed the title Can't change a org members project permissions to public user. Can't change a org members project permissions. Oct 4, 2016
@linzjax
Copy link
Contributor Author

linzjax commented Oct 4, 2016

According to the stack track It's this:

class EntityUserSerializer(serializers.Serializer):
    ...
    def to_internal_value(self, data):
        data[self.Meta.role_key] = self.set_roles(
            data.get(self.Meta.role_key, None)
        )
        return super().to_internal_value(data)

Because it's an immutable QueryDict

@linzjax
Copy link
Contributor Author

linzjax commented Oct 5, 2016

So this is actually related to #763. I was trying to change permissions on an archived project (not allowed), and it was just quietly ignoring me. So those projects definitely need to be hidden form org member views.

@linzjax
Copy link
Contributor Author

linzjax commented Oct 7, 2016

Archived projects are now hidden, so it's working fine.

@linzjax linzjax closed this as completed Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants