Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XForms: Attribute groups with similar labels will override each other #748

Closed
linzjax opened this issue Sep 29, 2016 · 3 comments
Closed

Comments

@linzjax
Copy link
Contributor

linzjax commented Sep 29, 2016

Steps to reproduce the error

image
If you have, say, two party_attribute groups with the same name, only the last one will remain.

[Please try to describe the actions that led to the incorrect behavior
in as much detail as possible.]

Actual behavior

The notes attribute field will only contain notes from party_attributes_individual

Expected behavior

The attributes should include notes from both party_attribute_individual and party_attributes_default

@linzjax linzjax added the bug label Sep 29, 2016
@linzjax
Copy link
Contributor Author

linzjax commented Oct 3, 2016

Now that I think through this, is this a bug? If you're assuming that all default attributes are included in parties, why would you need a notes field in individual attributes as well?

Are there situations where attribute groups would contain the same fields?

@dpalomino
Copy link

Hi @linzjax. I don't think this is a bug, at least I cannot imagine a case where there would be a need for having the same labels in different groups.

@dpalomino
Copy link

This is not something we will be fixing now, field names should be different.

Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants