Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xform errors are still visible after re-upload of working xform #679

Closed
oliverroick opened this issue Sep 13, 2016 · 5 comments
Closed

xform errors are still visible after re-upload of working xform #679

oliverroick opened this issue Sep 13, 2016 · 5 comments

Comments

@oliverroick
Copy link
Member

Steps to reproduce the error

  1. Upload this XLSForm to a project and save the project.
  2. You should see an error displayed with the form field.
  3. Upload this XLSForm to a project and save the project.

Actual behavior

The errors of the previous upload are still visible.

Expected behavior

The errors of the previous upload should be removed from the page when a valid XLSForm is uploaded.

@clash99
Copy link
Contributor

clash99 commented Sep 13, 2016

Related to #322

@wonderchook
Copy link
Contributor

@clash99 since this is related to #322 does it make sense to manage it during this sprint?

@wonderchook wonderchook added this to the Sprint 9 milestone Sep 14, 2016
@clash99
Copy link
Contributor

clash99 commented Sep 14, 2016

Yep, I'll take it!

@clash99 clash99 self-assigned this Sep 14, 2016
@dpalomino dpalomino added the bug label Sep 26, 2016
@bjohare bjohare self-assigned this Oct 4, 2016
@dpalomino dpalomino modified the milestones: Sprint 10, Sprint 9 Oct 17, 2016
@dpalomino
Copy link

@clash99, any feedback on this? Thanks!

@clash99
Copy link
Contributor

clash99 commented Nov 3, 2016

Added script so that when remove link is clicked, the error message below is hidden and the has-error class is removed from the form-group.

Screenshot Step 1: (initial view)

screenshot 2016-11-03 11 17 25

Screenshot Step 2: (attempting to upload bad file)

screenshot 2016-11-03 11 17 37

Screenshot Step 3: (after submit)

screenshot 2016-11-03 11 17 16

Screenshot Step 4: (remove link brings back to initial view)

screenshot 2016-11-03 11 17 25

I've added this to the two questionnaire file upload areas.

@bjohare The file upload uses a bit of a different flow (no remove link) so I don't know if we want to change that around to match at this time but if these types of file errors start to show, we can implement something similar on that page too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants