-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons to "add contact" and "remove contact" #451
Comments
@IvanSanchez thanks for the suggestion! |
@IvanSanchez There is no "remove contact" button on "add a new project page". Instead, there is a "cross mark" for removing contacts. Do I need to add a new button for removing contacts and then add icon to it? |
If I remember correctly, the "cross mark" does not look like a button. My suggestion is to replace the "cross mark" with a button with a "remove person" icon, and make the UI for the "add contact" functionality look the same, for consistency. |
@IvanSanchez Thanks :) |
Hi @Shruti9520 and @IvanSanchez - Thank you for your suggestions. We've decided to close this github task. One of the main reasons is that our parties icon is very similar as the contact icon used by bootstrap. We are in the process of reviewing our platform terminology and this could result in the renaming and updating of the parties icon but until then, it would be confusing to use the same icon for different entities. @Shruti9520 - please don't let this discourage you from submitting another bugfix for the purpose of Outreachy! |
@clash99 It's fine :) . I have learned many new things while working on this. :) |
In the "add a new project" page, add little icons to the "add contact" and "remove contact". Consider wrapping the "add contact" link inside a button, for UI consistency.
The text was updated successfully, but these errors were encountered: