Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to "add contact" and "remove contact" #451

Closed
IvanSanchez opened this issue Jul 14, 2016 · 6 comments
Closed

Add icons to "add contact" and "remove contact" #451

IvanSanchez opened this issue Jul 14, 2016 · 6 comments

Comments

@IvanSanchez
Copy link

In the "add a new project" page, add little icons to the "add contact" and "remove contact". Consider wrapping the "add contact" link inside a button, for UI consistency.

screenshot2

@wonderchook
Copy link
Contributor

@IvanSanchez thanks for the suggestion!

@Shruti9520
Copy link
Contributor

@IvanSanchez There is no "remove contact" button on "add a new project page". Instead, there is a "cross mark" for removing contacts. Do I need to add a new button for removing contacts and then add icon to it?

@IvanSanchez
Copy link
Author

If I remember correctly, the "cross mark" does not look like a button. My suggestion is to replace the "cross mark" with a button with a "remove person" icon, and make the UI for the "add contact" functionality look the same, for consistency.

@Shruti9520
Copy link
Contributor

Shruti9520 commented Feb 21, 2017

@IvanSanchez Thanks :)
Also, the version of bootstrap doesn't support "glyphicons glyphicons-user-add" class. Should I add images to buttons?

@clash99
Copy link
Contributor

clash99 commented Feb 21, 2017

Hi @Shruti9520 and @IvanSanchez -

Thank you for your suggestions. We've decided to close this github task. One of the main reasons is that our parties icon is very similar as the contact icon used by bootstrap. We are in the process of reviewing our platform terminology and this could result in the renaming and updating of the parties icon but until then, it would be confusing to use the same icon for different entities.

@Shruti9520 - please don't let this discourage you from submitting another bugfix for the purpose of Outreachy!

@clash99 clash99 closed this as completed Feb 21, 2017
@Shruti9520
Copy link
Contributor

@clash99 It's fine :) . I have learned many new things while working on this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants