Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for assignment of roles to users #29

Closed
ian-ross opened this issue Jan 28, 2016 · 7 comments
Closed

API for assignment of roles to users #29

ian-ross opened this issue Jan 28, 2016 · 7 comments
Assignees
Milestone

Comments

@ian-ross
Copy link
Contributor

There is a mechanism for assignment and de-assignment of roles to user accounts.

@ian-ross ian-ross added this to the Version 0.01.1 milestone Jan 28, 2016
@ian-ross ian-ross changed the title Assignment of roles to users API for assignment of roles to users Jan 28, 2016
@oliverroick oliverroick self-assigned this Mar 4, 2016
@oliverroick
Copy link
Member

I drafted an API design for user role management for organizations and projects. @Cadasta/cadasta-dev, I would like someone to cross-check if it makes sense, especially the bulk operations.

@seav
Copy link
Contributor

seav commented Mar 12, 2016

@oliverroick, currently, the roles given as examples are from the default set of user roles in #8. If there will be custom roles or new default user roles in the future, do we assume that these role identifiers ("org_admin", "manager", "collector") will not conflict with other fields like "projects", "id", and "name"? Would it be better to add a namespace, or restructure the JSON to make this clearer?

@seav
Copy link
Contributor

seav commented Mar 12, 2016

@oliverroick, I've added a bunch of comments to the document you shared

@ian-ross
Copy link
Contributor Author

@seav Thanks for those comments. I've responded to most of them, but I'll be moving all that API documentation onto GitHub on Monday, which might make discussions easier.

@ian-ross
Copy link
Contributor Author

@seav Oh, and to answer your question about the JSON field names: this fixed roles approach is a temporary measure before we develop a more sophisticated editable roles approach, so the namespacing shouldn't be a problem.

@oliverroick
Copy link
Member

This is implemented and ready for review. I'll rebase and open a PR as soon as the main project backend functionality is in master.

@ian-ross
Copy link
Contributor Author

I've reviewed this. It looks fine, although it will need another look before finally merging to make sure everything is OK after merging the main projects API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants