Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL validation seems off #1459

Closed
clash99 opened this issue May 2, 2017 · 2 comments
Closed

URL validation seems off #1459

clash99 opened this issue May 2, 2017 · 2 comments

Comments

@clash99
Copy link
Contributor

clash99 commented May 2, 2017

Steps to reproduce the error

When creating a new organization, enter an invalid url such as as.df in organization url field.

Actual behavior

Seems to accept any string with a period in it (doesn't accept asdf but does accept as.df)

Expected behavior

I would expect to get an error and that it wouldn't accept as.df as a url.

@seav
Copy link
Contributor

seav commented May 3, 2017

as.df is accepted by Django because it looks like a valid domain name. (Although .df is not currently an assigned CCTLD.)

@amplifi
Copy link
Contributor

amplifi commented May 3, 2017

Agreed; this is expected behavior and default for Django. URL validation checks that the string is formatted correctly, not that the URL entered corresponds to an existing domain/page. It would be unwieldy to continuously ensure that organization URLs are valid sites. For examples and definitions, see: https://mathiasbynens.be/demo/url-regex

@amplifi amplifi closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants