Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong style used in party detail page #1331

Closed
clash99 opened this issue Mar 22, 2017 · 3 comments
Closed

Wrong style used in party detail page #1331

clash99 opened this issue Mar 22, 2017 · 3 comments

Comments

@clash99
Copy link
Contributor

clash99 commented Mar 22, 2017

Steps to reproduce the error

Visit the detail page for a party

Actual behavior

Main panel had some shading that shouldn't bee there.

Expected behavior

Should use same layout and classes as Resources index.

Panel should resemble this page:
screenshot 2017-03-22 12 27 11

Currently looks like this (notice shading around panel):
screenshot 2017-03-22 12 27 31

At a glance I don't believe this requires a css change. I believe the error is on the html side for what styles are being called.

@clash99
Copy link
Contributor Author

clash99 commented Mar 22, 2017

@dpalomino - I marked this first contribution friendly. Feel free to update if you disagree. Thanks!

@pyaf
Copy link

pyaf commented Mar 23, 2017

@clash99 I have looked into it and I found that in party/party_detail.html there's an extra css class default attached with panel div, removing it fixes this issue.
so basically div.panel-body.detail needs to be changed to div.panel-body.
I would open a PR if you say so.

@clash99
Copy link
Contributor Author

clash99 commented Mar 23, 2017

Sounds good @rishabhiitbhu - make it happen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants