Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project data language selector UI can be improved #1282

Closed
seav opened this issue Mar 10, 2017 · 13 comments
Closed

Project data language selector UI can be improved #1282

seav opened this issue Mar 10, 2017 · 13 comments

Comments

@seav
Copy link
Contributor

seav commented Mar 10, 2017

  1. When a user has no permission to view project data, the project data language selector still appears even though it's useless for the user.
  2. On smaller screens, the selector and its tool tip are not displayed properly.

screen shot 2017-03-11 at 00 52 35

@sourabhtk37
Copy link

Taking this up

@oliverroick
Copy link
Member

@sourabhtk37 Please provide an outline how you want to approach to fix this issue before starting the work. Please refer to the Issue Contribution Process for more information

@sourabhtk37
Copy link

sourabhtk37 commented Mar 13, 2017

Put a check on template checking whether the user has permission or not.
something like {% if user.permissions % }.
Please do suggest any other method. @oliverroick

@oliverroick
Copy link
Member

@sourabhtk37 How will you find out how a user has permission or not?

@sourabhtk37
Copy link

tutelary can check for the permission I suppose. Can you guide me as the code is not well commented(I can help you in commenting the code, but I need a better understanding from something like a sitemap).

@mikael19
Copy link

Hi @oliverroick @sourabhtk37 @seav @wonderchook ,
please is there any update on this?
I would like to work on this, if there are no updates.

Thanks

@sourabhtk37
Copy link

@Kera99 This is a low priority bug, so focus is on other issues rt now but feel free to share your approach.

@mikael19
Copy link

@sourabhtk37 Here is how I would go about the issue:

  • In the organization/views/default.py, I will make sure that the require permission is passed in the context data of the page displayed. If it is not, I shall add it(The permissions are stored in the db).

  • In the template concerned, I shall isolate the header block that contains the language selection. I shall basically put it in a seperated file and include it in the block of the parent page. Then, in the child page, I shall override this block by passing the page name as a variable in the header block.

This way, I shall have a seperate header file that can be configured and overriden from the child pages.

@clash99
Copy link
Contributor

clash99 commented Apr 11, 2017

I'm making adjustments to css file for smaller screens.

screenshot 2017-04-11 15 55 03

This spacing is a bit off around this dropdown but this dropdown will move with the map interactions project. Ideally only the value (EN or BN) would show on responsive screens and a "more info" link could be contained in the dropdown potentially.

@oliverroick
Copy link
Member

We need to verify if this is still an issue. I believe both bugs should be fixed now.

@clash99 clash99 self-assigned this Sep 21, 2017
@clash99
Copy link
Contributor

clash99 commented Sep 21, 2017

Also related is that inlinemanual launcher sits on top open user menu.

screenshot 2017-09-21 16 23 01

@clash99
Copy link
Contributor

clash99 commented Sep 21, 2017

Updated z-index for launcher in inlinemanual on all three sites.

@clash99
Copy link
Contributor

clash99 commented Sep 21, 2017

CSS is fixed for responsive:

screenshot 2017-09-21 16 39 24

screenshot 2017-09-21 16 39 17

screenshot 2017-09-21 16 40 43

@clash99 clash99 closed this as completed Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants