Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3 Image enhancements #82

Merged
merged 4 commits into from
May 27, 2016
Merged

2.3 Image enhancements #82

merged 4 commits into from
May 27, 2016

Conversation

djdefi
Copy link
Contributor

@djdefi djdefi commented May 27, 2016

  • Run more things as www-data user
  • Use ENV in Dockerfile to specify Cachet version (simplify new release process)
  • Run php-fpm workers on-demand rather than preforking
  • disable supervisor http socket (not used)
  • Take advantage of ARG in Dockerfile to allow specifying cachet_ver during manual builds

Merging these fixes back into master, then will cut a 2.3.0 tag and release when it is released upstream.

@djdefi djdefi mentioned this pull request May 27, 2016
@@ -6,11 +6,10 @@ listen = 9000

request_terminate_timeout = 120s

pm = dynamic
pm = ondemand
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what at the advantages here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor reduction in RAM utilization on an idle system. Performance should be about the same overall.

Per https://ma.ttias.be/a-better-way-to-run-php-fpm/

Copy link
Contributor

@GrahamCampbell GrahamCampbell May 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, ok

@djdefi
Copy link
Contributor Author

djdefi commented May 27, 2016

Ran through tests of the app, everything seems to be working just fine. There was a issue with a 500 when saving an incident on the pre 2.3enhance image iteration which is not happening now.

@djdefi djdefi merged commit 6de3691 into master May 27, 2016
@djdefi djdefi deleted the 2.3enhance branch May 27, 2016 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants