Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx as container instead internal instance #43

Closed
zemirco opened this issue Feb 22, 2016 · 3 comments
Closed

nginx as container instead internal instance #43

zemirco opened this issue Feb 22, 2016 · 3 comments

Comments

@zemirco
Copy link
Contributor

zemirco commented Feb 22, 2016

Hey,

cachet is pretty cool and especially this Docker version makes it very easy to get started. Great work!

I'm currently trying to setup https://.... Currently nginx is tightly integrated into the dockerfile. Wouldn't it be better / more flexible to use a separate nginx container via docker-compose? That would allow for using a custom nginx setup with ssl termination etc.

At the moment I would need a second nginx instance to handle ssl, i.e. nginx ssl -> internal nginx -> cachet.

If that's OK with you I'll start working on a pull request.

@djdefi
Copy link
Contributor

djdefi commented Feb 26, 2016

Sounds great to me, as long as we don't need to build and maintain our own custom nginx / fpm images and can use official ones.

@zemirco
Copy link
Contributor Author

zemirco commented Feb 28, 2016

Sent a pull request #46

@djdefi
Copy link
Contributor

djdefi commented Mar 3, 2016

Implemented in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants