Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Base image #4

Closed
djdefi opened this issue Aug 13, 2015 · 11 comments
Closed

Create a Base image #4

djdefi opened this issue Aug 13, 2015 · 11 comments
Assignees

Comments

@djdefi
Copy link
Contributor

djdefi commented Aug 13, 2015

We should have a base image that does all of the apt-get installs and other configurations.

Then we would use this as the FROM for the images that pull down Cachet, and do the composer install and finalization.

@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

Is wfjsw/Cachet-Docker-Base ok?

@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

CI finished with some errors

mv: cannot stat '/var/www/html/docker/php-fpm-pool.conf': No such file or directory
mv: cannot stat '/var/www/html/docker/nginx-site.conf': No such file or directory
rm: cannot remove '/var/www/html/docker': No such file or directory

Will fix it later

@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

Fixed :)

@djdefi
Copy link
Contributor Author

djdefi commented Aug 14, 2015

Should we move that into this repo under a subfolder named base - Then we can make a docker hub build pointed at that directory called cachethq/cachet:base

Then the images built from that would start with FROM cachethq/cachet:base

@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

Is that ok? I will make the change in minutes :p

@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

I gonna build a test Cachet in top of it before I publicly release that.

@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

Oops, it cause my CI broke

UPDATE: Backported coz it makes my head explode

@djdefi
Copy link
Contributor Author

djdefi commented Aug 14, 2015

No worries @wfjsw - Looks like you are off to a good start :)

@jbrooksuk
Copy link
Member

If you need a new repo creating let me know.

@wfjsw wfjsw self-assigned this Aug 14, 2015
@wfjsw
Copy link
Contributor

wfjsw commented Aug 14, 2015

Image built successfully. Need some test (run phpunit?)

@wfjsw wfjsw mentioned this issue Aug 14, 2015
@wfjsw
Copy link
Contributor

wfjsw commented Aug 16, 2015

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants