Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewable Logic: Fix falsey check for empty Operation Def value viewLabels showing their value instead of blank #166

Closed
CWolfs opened this issue Jun 5, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@CWolfs
Copy link
Owner

CWolfs commented Jun 5, 2023

Viewable Logic: Fix falsey check for empty Operation Def value viewLabels showing their value instead of blank

Basically, if you had:

    {
      "label": "Force Non-FP Conference Room",
      "types": ["int"],
      "tooltip": "If this is true, when a conversation is triggered it will force the non-FP version of the conference room",
      "values": [
        {
          "viewlabel": "",
          "text": "False",
          "value": 0
        },
        {
          "viewlabel": "always in the non-FP conference room ",
          "text": "True",
          "value": 1
        }
      ],
      "defaultValue": 0
    },

The "viewlabel": "", section should mean nothing should appear for this section but instead it shows 'False'.

@CWolfs CWolfs added the bug Something isn't working label Jun 5, 2023
@CWolfs CWolfs added this to the v1.6.0 milestone Jun 5, 2023
@CWolfs CWolfs changed the title Viewable Logic: Fixed falsey check for empty Operation Def value viewLabels showing their value instead of blank Viewable Logic: Fix falsey check for empty Operation Def value viewLabels showing their value instead of blank Jun 5, 2023
@CWolfs
Copy link
Owner Author

CWolfs commented Jun 5, 2023

In develop. It now shows blank correctly.

@CWolfs CWolfs closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant