Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Export empty instead of 0 for seek position times #17

Open
barbeau opened this issue Aug 20, 2021 · 1 comment
Open

Export empty instead of 0 for seek position times #17

barbeau opened this issue Aug 20, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@barbeau
Copy link
Member

barbeau commented Aug 20, 2021

In the MUSER app, we attempt to get the seek position of the song when an event is triggered. For example, the user taps on the screen Play button, and we generate a UI event for PLAY and a player event for PLAY when the song starts playing.

Depending on the state of player, the seek position may not be available at certain times. In that case, the function to get the position returns 0:
https://github.com/CUTR-at-USF/MUSER/blob/usf/app/src/main/java/com/simplecity/amp_library/utils/MusicServiceConnectionUtils.java#L99

For this reason, when we're exporting the data, we should leave the seek position blank/empty in the CSV file instead of outputting a 0 value.

@barbeau barbeau added the enhancement New feature or request label Aug 20, 2021
@barbeau barbeau added this to the MVP milestone Aug 20, 2021
@barbeau
Copy link
Member Author

barbeau commented Aug 20, 2021

@kanch21 FYI, I've opened this issue so we can change how the data is exported for seek position. We should output empty data instead of 0 value to make it clearer that real seek position data wasn't available. We can talk next week about who implements this. cc @antcoder007

@barbeau barbeau changed the title Output empty instead of 0 for seek position times Export empty instead of 0 for seek position times Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant