Skip to content
This repository has been archived by the owner on Sep 5, 2022. It is now read-only.

Add ESLint and Some Sort Of Code Linting CI Check #24

Closed
alexfinnarn opened this issue May 27, 2020 · 1 comment · Fixed by #57
Closed

Add ESLint and Some Sort Of Code Linting CI Check #24

alexfinnarn opened this issue May 27, 2020 · 1 comment · Fixed by #57

Comments

@alexfinnarn
Copy link
Contributor

Need to have code format checking and have it run on every PR.

@alexfinnarn
Copy link
Contributor Author

The main weirdness here is with the Link component and Next.js. It makes you use an inaccessible <a> tag, but when rendered, the link is complaint with accessibility standards.

jsx-eslint/eslint-plugin-jsx-a11y#402 (comment)

A follow up issue would have to be made to correct that, but I won't add linting during CI checks until I've added all components and pages from the MVP app.

alexfinnarn pushed a commit that referenced this issue Jun 15, 2020
Issue #24: Adding eslint and config files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant