Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filter functionality #685

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Mar 2, 2022

Description

Draft submissions and Published submissions can be filtered by their Name in the filter box Filter By Name

Related issues

Closes issue 423

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • The filter is implemented in front-end by fetching all draft submissions and published submissions, then filtering submission names from those lists.
  • The filter can return all matched characters
  • The pagination is updated to work with filtered list as well as when deleting a submission from filtered list
  • Using lodash debounce and react useMemo() to improve the filter performance
  • Updated integration tests regarding filtering and pagination

Testing

  • Integration Tests

@hannyle hannyle self-assigned this Mar 2, 2022
@hannyle hannyle added the enhancement New feature or request label Mar 2, 2022
@hannyle hannyle added this to the 0.12.0 milestone Mar 2, 2022
@hannyle hannyle linked an issue Mar 2, 2022 that may be closed by this pull request
@hannyle hannyle force-pushed the feature/filter-functionality branch 2 times, most recently from 4432e84 to 8a82bc4 Compare March 3, 2022 12:44
@hannyle hannyle force-pushed the feature/filter-functionality branch from 8a82bc4 to b99415f Compare March 3, 2022 13:47
@saulipurhonen
Copy link
Contributor

@blankdots, @hannyle would it make sense to be able to sort also by folder name, last modified by and CSC project fields?

Otherwise looks good to me!

@hannyle
Copy link
Contributor Author

hannyle commented Mar 4, 2022

@blankdots, @hannyle would it make sense to be able to sort also by folder name, last modified by and CSC project fields?

Otherwise looks good to me!

I think it totally makes sense to be able to sort the folder name and last modified. The CSC project column would be removed in the next PR about the issue #625

@hannyle hannyle force-pushed the feature/filter-functionality branch from b99415f to 24a00f2 Compare March 7, 2022 10:07
@saulipurhonen saulipurhonen merged commit f1abb7b into develop Mar 8, 2022
@saulipurhonen saulipurhonen deleted the feature/filter-functionality branch March 8, 2022 04:45
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter user folders and drafts and templates
3 participants