Feature/workflows node js update #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
suggested changes
Feb 3, 2022
There was a problem hiding this comment.
https://github.com/CSCfi/metadata-submitter-frontend/blob/develop/Dockerfile-dev - update that as well ?
blankdots
approved these changes
Feb 3, 2022
|
maybe change it in readme as well ? |
2 tasks
blankdots
reviewed
Feb 3, 2022
There was a problem hiding this comment.
https://github.com/CSCfi/metadata-submitter-frontend/blob/develop/.github/workflows/e2etests.yml#L16 can also be removed now I assume
blankdots
approved these changes
Feb 3, 2022
hannyle
approved these changes
Feb 8, 2022
saulipurhonen
force-pushed
the
feature/workflows-node-js-update
branch
from
cb34903 to
5e616f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node.js versions from 16.11.0 and up use NPM v8 which is what we want to use in development.
Related issues
Closes #654
Type of change
Changes Made
Testing