-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/date picker #559
Feature/date picker #559
Conversation
636ea46
to
479620c
Compare
479620c
to
3c5fa06
Compare
3c5fa06
to
92eba4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works like expected.
maybe we can rebase this, so we can merge it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, :) some wrapping to get calendar there. Maybe when styling we could improve the error message that now says "Please select an item in the list" to something saying about the calendar.
e85b29e
to
70390bd
Compare
The PR is rebased and will be merged to |
70390bd
to
fb1e5c4
Compare
Description
In DOI form >
Dates
, adding Date picker to pick a date or a date-range.Related issues
Closes #498
Type of change
Changes Made
DatePicker
componentDatePicker
to work in different screen sizes (the standard way of implementing it now in MUI v.5 has a bug with smaller screens)(took me a while to realise this issue)FormDatePicker
has been updated with MUI v.5's new styling ways for its specific components (usingsx
andstyled
)Start
andEnd
datesmoment.js
(which was chosen and included in the library to used withDatePicker
) to format the datesTesting