Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/date picker #559

Merged
merged 12 commits into from
Dec 30, 2021
Merged

Feature/date picker #559

merged 12 commits into from
Dec 30, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Dec 2, 2021

Description

In DOI form > Dates, adding Date picker to pick a date or a date-range.

Related issues

Closes #498

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Implemented using MUI v.5 DatePicker component
  • Customised the DatePicker to work in different screen sizes (the standard way of implementing it now in MUI v.5 has a bug with smaller screens)(took me a while to realise this issue)
  • Followed up PR Feature/upgrade to Material-UI version 5 #543, FormDatePicker has been updated with MUI v.5's new styling ways for its specific components (using sx and styled)
  • Made two different components for selecting Start and End dates
  • Used moment.js (which was chosen and included in the library to used with DatePicker) to format the dates
  • Handled input dates according to RKMS-ISO8601 guidelines for date ranges
  • Added e2e test for selecting dates and saving DOI form successfully

Testing

  • Integration Tests

@hannyle hannyle force-pushed the feature/date-picker branch 8 times, most recently from 636ea46 to 479620c Compare December 3, 2021 13:21
@hannyle hannyle self-assigned this Dec 3, 2021
@hannyle hannyle added enhancement New feature or request frontend frontend issue labels Dec 3, 2021
@hannyle hannyle linked an issue Dec 3, 2021 that may be closed by this pull request
@hannyle hannyle force-pushed the feature/date-picker branch from 479620c to 3c5fa06 Compare December 3, 2021 13:47
@hannyle hannyle force-pushed the feature/date-picker branch from 3c5fa06 to 92eba4f Compare December 3, 2021 14:38
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like expected.

@blankdots
Copy link
Contributor

maybe we can rebase this, so we can merge it ?

Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :) some wrapping to get calendar there. Maybe when styling we could improve the error message that now says "Please select an item in the list" to something saying about the calendar.

@hannyle hannyle force-pushed the feature/date-picker branch 2 times, most recently from e85b29e to 70390bd Compare December 30, 2021 13:48
@hannyle
Copy link
Contributor Author

hannyle commented Dec 30, 2021

The PR is rebased and will be merged to develop

@hannyle hannyle force-pushed the feature/date-picker branch from 70390bd to fb1e5c4 Compare December 30, 2021 14:43
@hannyle hannyle merged commit b4668df into develop Dec 30, 2021
@hannyle hannyle deleted the feature/date-picker branch December 30, 2021 15:00
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend frontend issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Date Picker on Date field from DOI submission
3 participants