Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deletion of draft templates #499

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Enable deletion of draft templates #499

merged 2 commits into from
Oct 29, 2021

Conversation

saulipurhonen
Copy link
Contributor

Description

Give user option to delete draft templates. Delete button is rendered inside template specific menu.

Related issues

Closes #487
Can be extended for #488

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Render template specific menu
  • Handle deletion of template from both backend and redux state
  • Component for template actions
  • Added E2E test case for deleting template

Testing

  • E2E

@saulipurhonen saulipurhonen self-assigned this Oct 17, 2021
@saulipurhonen saulipurhonen added the enhancement New feature or request label Oct 17, 2021
@saulipurhonen saulipurhonen added this to the Open Beta milestone Oct 17, 2021
@saulipurhonen saulipurhonen force-pushed the feature/delete-draft-templates branch from 6cbc7fc to 11de60f Compare October 17, 2021 10:30
@saulipurhonen saulipurhonen marked this pull request as ready for review October 17, 2021 10:44
lilachic
lilachic approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe merge this one first, to get the newer things from PR495 and 493?

@hannyle hannyle force-pushed the feature/delete-draft-templates branch from 11de60f to 7d0208d Compare October 29, 2021 12:55
@hannyle
Copy link
Contributor

hannyle commented Oct 29, 2021

LGTM. Maybe merge this one first, to get the newer things from PR495 and 493?

Yes you're right. Sorry I didn't see your comments earlier. I pushed some fixes for merging errors.

@hannyle hannyle force-pushed the feature/delete-draft-templates branch from 2027a80 to fd4f9de Compare October 29, 2021 13:09
@hannyle hannyle merged commit 19a90bc into develop Oct 29, 2021
@hannyle hannyle deleted the feature/delete-draft-templates branch October 29, 2021 13:26
@saulipurhonen saulipurhonen linked an issue Nov 1, 2021 that may be closed by this pull request
Add option to Delete user templates #487
Closed
@blankdots blankdots mentioned this pull request Apr 7, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilachic lilachic lilachic approved these changes

@hannyle hannyle Awaiting requested review from hannyle

@blankdots blankdots Awaiting requested review from blankdots

Assignees

@saulipurhonen saulipurhonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
Open Beta
Development

Successfully merging this pull request may close these issues.

Add option to Delete user templates
3 participants
@saulipurhonen @hannyle @lilachic