Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/using draft templates #475

Merged
merged 12 commits into from
Oct 7, 2021
Merged

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Oct 5, 2021

Description

  • WizardFrontPageStep is removed. Now when clicking Create Submission it goes straight to Folder form filling step.

  • After saving templates, users can select multiple templates and reuse them as drafts when creating a new submission or when editing a submission.

Related issues

#247

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Remove WizardFrontPageStep from Create Submission steps
  • Modify API requests from drafts to templates based on back-end for adding drafts as templates and getting the templates
  • Add Checkbox for templates so users can select them to use
  • Modify Folder form's submit function so that the templates can be added at the same time a folder is created or updated
  • Add different Hook files for saving templates and adding templates to folder
  • Update cypress tests

Testing

  • Integration Tests

@hannyle hannyle self-assigned this Oct 5, 2021
@hannyle hannyle added the enhancement New feature or request label Oct 5, 2021
@hannyle hannyle added this to the Open Beta milestone Oct 5, 2021
@hannyle hannyle linked an issue Oct 5, 2021 that may be closed by this pull request
@hannyle hannyle force-pushed the feature/using-draft-templates branch from 784c001 to 106e5bd Compare October 5, 2021 11:23
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with using one and multiple templates in a submission, and advertised behaviour is there: A user can use templates in a submission.

Not sure if this is a problem, but if a user selects a template for a submission and does not fill that draft, it might end up saving it as template, thus resulting in multiple duplicate templates - This might be a non-issue, so let us see how it will turn out in practice.

@hannyle
Copy link
Contributor Author

hannyle commented Oct 6, 2021

Tested with using one and multiple templates in a submission, and advertised behaviour is there: A user can use templates in a submission.

Not sure if this is a problem, but if a user selects a template for a submission and does not fill that draft, it might end up saving it as template, thus resulting in multiple duplicate templates - This might be a non-issue, so let us see how it will turn out in practice.

I understand. This relates to user experience so yes, we'll see.

@saulipurhonen
Copy link
Contributor

Tested and works as supposed.

What could be improved (on other PR) is to separate templates from drafts. This could fix the UX issue @blankdots mentioned.
In this scenario user checks templates the user wants to use. Templates would appear as separate list at the sidebar with submitted / draft objects.

@blankdots
Copy link
Contributor

Tested and works as supposed.

What could be improved (on other PR) is to separate templates from drafts. This could fix the UX issue @blankdots mentioned.
In this scenario user checks templates the user wants to use. Templates would appear as separate list at the sidebar with submitted / draft objects.

indeed a good idea, however i suggest to wait on this change/issue till #363 is started to be sure we don't do the work twice.

@hannyle
Copy link
Contributor Author

hannyle commented Oct 6, 2021

Tested and works as supposed.
What could be improved (on other PR) is to separate templates from drafts. This could fix the UX issue @blankdots mentioned.
In this scenario user checks templates the user wants to use. Templates would appear as separate list at the sidebar with submitted / draft objects.

indeed a good idea, however i suggest to wait on this change/issue till #363 is started to be sure we don't do the work twice.

I agree. In fact there are some proposed solutions for highlighting templates from drafts in the new UI (WIP) as well. We shall see when we start to do the UI improvement.

@blankdots blankdots merged commit 3460cfe into develop Oct 7, 2021
@blankdots blankdots deleted the feature/using-draft-templates branch October 7, 2021 05:03
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of draft templates when creating a submission
3 participants