-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/using draft templates #475
Conversation
784c001
to
106e5bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with using one and multiple templates in a submission, and advertised behaviour is there: A user can use templates in a submission.
Not sure if this is a problem, but if a user selects a template for a submission and does not fill that draft, it might end up saving it as template, thus resulting in multiple duplicate templates - This might be a non-issue, so let us see how it will turn out in practice.
I understand. This relates to user experience so yes, we'll see. |
Tested and works as supposed. What could be improved (on other PR) is to separate templates from drafts. This could fix the UX issue @blankdots mentioned. |
indeed a good idea, however i suggest to wait on this change/issue till #363 is started to be sure we don't do the work twice. |
I agree. In fact there are some proposed solutions for highlighting templates from drafts in the new UI (WIP) as well. We shall see when we start to do the UI improvement. |
Description
WizardFrontPageStep
is removed. Now when clickingCreate Submission
it goes straight to Folder form filling step.After saving templates, users can select multiple templates and reuse them as drafts when creating a new submission or when editing a submission.
Related issues
#247
Type of change
Changes Made
WizardFrontPageStep
from Create Submission stepsdrafts
totemplates
based on back-end for adding drafts as templates and getting the templatesCheckbox
for templates so users can select them to usesubmit
function so that the templates can be added at the same time a folder is created or updatedTesting