Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error checks for folder related backend operations #65

Closed
otahontas opened this issue Aug 13, 2020 · 0 comments · Fixed by #97
Closed

Add error checks for folder related backend operations #65

otahontas opened this issue Aug 13, 2020 · 0 comments · Fixed by #97
Assignees
Labels
enhancement New feature or request

Comments

@otahontas
Copy link
Contributor

otahontas commented Aug 13, 2020

Proposed solution

Currently results from folder-related backend operations are not checked, so if backend is not running / request fails, wizard will just continue and crash later.

Following situations are problematic currently:

  • Addition of folders: if posting to backend fails, wizard continues to second step
  • Addition of objects to folders: if adding to folder fails in backend, nothing is reported (however folder isn't added to redux store in frontend, which is good). As a result, object is in backend, but not connected to folder
  • Deletion of folder: if deleting folder or objects inside it fails, nothing is reported (also folder is not removed from store at all if any of requests to backend fails).

We should handle error checks for backend operations and report fails to user + in best situation these.

DoD (Definition of Done)

Errors are checked and handled accordingly, user is notified

@otahontas otahontas added the enhancement New feature or request label Aug 13, 2020
@saulipurhonen saulipurhonen self-assigned this Nov 11, 2020
@saulipurhonen saulipurhonen linked a pull request Nov 13, 2020 that will close this issue
2 tasks
@blankdots blankdots mentioned this issue Nov 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants