Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit does not work for all fields #256

Closed
blankdots opened this issue Apr 19, 2021 · 1 comment
Closed

Edit does not work for all fields #256

blankdots opened this issue Apr 19, 2021 · 1 comment
Assignees
@saulipurhonen
Labels
bug Something isn't working
Milestone
Beta - User Inter...

Comments

@blankdots
Copy link
Contributor

blankdots commented Apr 19, 2021 •
edited
Loading

Describe the bug

Edit does not seem to work for all fields for Sample, Experiment, Analysis and Run

Please add integration tests to prevent this from happening

To Reproduce

Steps to reproduce the behaviour:

  1. Go to Create Submission to create folder
  2. Click on an object Sample
  3. Fill in form with required filed and also Sample Data Type
  4. Submit form
  5. clear form
  6. edit previous form and see how Sample Data Type does not get proper data
  7. See screenshots for other schema types

Expected behavior

Sample Data Type for Sample does gets proper data when edit is pressed
All fields get the right information to edit.

Screenshots

Sample

Peek 2021-04-19 13-15

Experiment

Peek 2021-04-19 14-28

Run

Peek 2021-04-19 14-30

Analysis
Peek 2021-04-19 14-31

Additional context
@blankdots blankdots added the bug Something isn't working label Apr 19, 2021
@blankdots blankdots mentioned this issue Apr 19, 2021
Merged
3 tasks
@blankdots blankdots added this to the Beta - User Interaction milestone Apr 21, 2021
@blankdots blankdots mentioned this issue May 5, 2021
Closed
@saulipurhonen saulipurhonen self-assigned this May 24, 2021
@saulipurhonen
Copy link
Contributor

#294 is blocking testing for possible solution.

@saulipurhonen saulipurhonen mentioned this issue May 28, 2021
Merged
2 tasks
@hannyle hannyle mentioned this issue Jun 16, 2021
Closed
3 tasks
@hannyle hannyle linked a pull request Jun 16, 2021 that will close this issue
Bugfix/useFieldArray #344
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saulipurhonen saulipurhonen

Labels
bug Something isn't working
Projects
None yet
Milestone
Beta - User Interaction
Development

Successfully merging a pull request may close this issue.

Bugfix/useFieldArray CSCfi/metadata-submitter-frontend
2 participants
@blankdots @saulipurhonen