Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit and delete functionality to submitted objects #144

Closed
blankdots opened this issue Feb 1, 2021 · 2 comments · Fixed by #161
Closed

Add edit and delete functionality to submitted objects #144

blankdots opened this issue Feb 1, 2021 · 2 comments · Fixed by #161
Assignees
Milestone

Comments

@blankdots
Copy link
Contributor

blankdots commented Feb 1, 2021

Description

We need to be able to resume editing an object, the submission summary on the right hand side should contain a button group with edit and delete

image

The same goes for the summary at the end of the submission:

image

DoD (Definition of Done)

Ability to edit and delete submitted objects.

Testing

Unit test and Integration testing

@blankdots blankdots added this to the MVP milestone Feb 1, 2021
@saulipurhonen saulipurhonen self-assigned this Feb 3, 2021
@saulipurhonen
Copy link
Contributor

@blankdots what about XML uploads? Those show in the listing too but I think edit functionality would be weird since only option would be to replace the file. I suggest that we show only delete button on XML submissions. This requires #94 so we can get submission type for metaDataObjects.

@blankdots
Copy link
Contributor Author

blankdots commented Feb 3, 2021

yes, XML uploads probably the only way to edit would be to re-upload, but not sure we offer a PUT for XML but not PATCH so we can patch form, meaning edit data but for XML we will replace it. and maybe the labels should reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants