Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on week 7 project progress #52

Closed
24 of 25 tasks
nus-pe-script opened this issue Mar 5, 2019 · 3 comments
Closed
24 of 25 tasks

Feedback on week 7 project progress #52

nus-pe-script opened this issue Mar 5, 2019 · 3 comments

Comments

@nus-pe-script
Copy link

nus-pe-script commented Mar 5, 2019

Subject: feedback on week 7 project progress

See v1.1 progress guide for more details of the activities mentioned below.

Team progress

  • Team org and repo set up correctly (:heavy_check_mark: well done!)
  • PR created from team repo to AB-3 or AB-4 (:heavy_check_mark: well done!)
  • Auto-publishing set up for the team repo (:heavy_check_mark: well done!)
  • README page:
    • Ui.png has been updated (:exclamation: try to do by next milestone)
    • Parts not related to your product are removed (:heavy_check_mark: well done!)
    • se-edu/addressbook-level4 acknowledged (:heavy_check_mark: well done!)
  • User Guide: some content has been updated (:heavy_check_mark: well done!)
  • Developer Guide: some content has been updated (:heavy_check_mark: well done!)
  • Team repo git tagged as v1.1 (:heavy_check_mark: well done!)

Individual progress of @macchazuki

  • Used forking workflow:
    • Created PRs link (:heavy_check_mark: well done!)
    • Gave review comments to other PRs (:exclamation: try to do by next milestone)
  • Merged updates to documents (:heavy_check_mark: well done!)
  • macchazuki.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Individual progress of @dingheng4448

  • Used forking workflow:
    • Created PRs link (:heavy_check_mark: well done!)
    • Gave review comments to other PRs (:heavy_check_mark: well done!)
  • Merged updates to documents (:heavy_check_mark: well done!)
  • dingheng4448.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Individual progress of @marcus-pzj

  • Used forking workflow:
    • Created PRs link (:heavy_check_mark: well done!)
    • Gave review comments to other PRs (:heavy_check_mark: well done!)
  • Merged updates to documents (:heavy_check_mark: well done!)
  • marcus-pzj.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Individual progress of @seanieyap

  • Used forking workflow:
    • Created PRs link (:heavy_check_mark: well done!)
    • Gave review comments to other PRs (:heavy_check_mark: well done!)
  • Merged updates to documents (:heavy_check_mark: well done!)
  • seanieyap.png uploaded and linked from AboutUs page in png format (change image to png if presently in different format) (:heavy_check_mark: well done!)

Tutor: @0WN463

Note: the above observation was done by the CS2113-feedback-bot and covers changes up to 2019-03-05 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

@dingheng4448
Copy link

dingheng4448 commented Mar 5, 2019

@0WN463

Feedback for Ui.png is incorrect.

Our updated image can be found at https://github.com/CS2113-AY1819S2-T08-3/main/blob/master/docs/images/Ui.png which is in accordance with the requirement "image of the UI should be docs/images/Ui.png so that it can be downloaded by our scripts."

@nus-pe-script
Copy link
Author

Hi @dingheng4448 ,

Was this ui.png updated using a PR? Please note that the bot ONLY looks at PRs.
Anyhow, we have updated our records to reflect this change.

Regards,
CS2113-feedback-team

@dingheng4448
Copy link

PR was made to update Ui.png (https://github.com/CS2113-AY1819S2-T08-3/main/pull/45/files). Could there be a problem elsewhere which resulted in the update being undetected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants