diff --git a/docs/DeveloperGuide.adoc b/docs/DeveloperGuide.adoc index 0d4199419..029de5bfb 100644 --- a/docs/DeveloperGuide.adoc +++ b/docs/DeveloperGuide.adoc @@ -650,7 +650,7 @@ The maximum Levenshtein Distance set in `PlanMySem` is 20. The weighted `Slots` are inserted into a `PriorityQueue` and the closest matching `Slots` will be polled into the output list. + -Upon executing the `find` command with valid parameters (refer to <> for `find` usage), +Upon executing the `find` command with valid parameters, a sequence of events is executed. The sequence of events illustrated in the Sequence Diagram below will be in reference to the execution of a `find n/keyword` command. The sequence of events are as follows: diff --git a/docs/team/marcus-pzj.adoc b/docs/team/marcus-pzj.adoc index b1a382768..fba721fce 100644 --- a/docs/team/marcus-pzj.adoc +++ b/docs/team/marcus-pzj.adoc @@ -81,12 +81,12 @@ image::FindListHistoryActivityDiagram.png[width="800"] Essentially, if the user knows the exact keyword to use to locate his/her desired [blue]`Slot`, he would use the `list` command. Otherwise, the `find` command is recommended for use. As a parallel process, [blue]`CommandHistory` records the user input and saves it to [blue]`Planner's` history. -* *Code contributed*: [https://nuscs2113-ay1819s2.github.io/dashboard-beta/#search=marcus-pzj&sort=displayName&since=2019-02-10&until=2019-04-01&timeframe=day&reverse=false&groupSelect=groupByRepos&breakdown=false&tabAuthor=marcus-pzj&tabRepo=CS2113-AY1819S2-T08-3_main_master[RepoSense]] [https://github.com/CS2113-AY1819S2-T08-3/main/pulls?q=is%3Apr+author%3Amarcus-pzj+is%3Aclosed[Pull Requests]] +* *Code contributed*: [https://nuscs2113-ay1819s2.github.io/dashboard-beta/#search=marcus-pzj&sort=displayName&since=2019-02-10&until=2019-04-14&timeframe=day&reverse=false&groupSelect=groupByRepos&breakdown=false&tabAuthor=marcus-pzj&tabRepo=CS2113-AY1819S2-T08-3_main_master&repoSort=true[RepoSense]] [https://github.com/CS2113-AY1819S2-T08-3/main/pulls?q=is%3Apr+author%3Amarcus-pzj+is%3Aclosed[Pull Requests]] * *Other contributions*: ** Project management: -*** I managed releases from version 1.1 to 1.3, which are all of the https://github.com/CS2113-AY1819S2-T08-3/main/releases[releases] on GitHub. +*** I managed releases from version 1.1 to 1.4, which are all of the https://github.com/CS2113-AY1819S2-T08-3/main/releases[releases] on GitHub. ** Enhancement to existing features: *** I wrote additional tests for existing features to increase coverage. ** Documentation: @@ -161,7 +161,7 @@ Here are the links to my contributed sections in the Developer Guide: - List Command: https://github.com/CS2113-AY1819S2-T08-3/main/blob/master/docs/DeveloperGuide.adoc#list-feature[`list`] - Find Command: https://github.com/CS2113-AY1819S2-T08-3/main/blob/master/docs/DeveloperGuide.adoc#find-feature[`find`] -- Undo & Redo Command: https://github.com/CS2113-AY1819S2-T08-3/main/blob/master/docs/DeveloperGuide.adoc#undo-redo-feature[`undo` & `redo`] +- Undo & Redo Command: https://github.com/CS2113-AY1819S2-T08-3/main/blob/master/docs/DeveloperGuide.adoc#undoredo-feature[`undo` & `redo`] - User Stories: https://github.com/CS2113-AY1819S2-T08-3/main/blob/master/docs/DeveloperGuide.adoc#user-stories[User Stories] Below is an example of my addition to the Developer Guide for the `find` feature. @@ -185,7 +185,7 @@ The maximum Levenshtein Distance set in *PlanMySem* is 20. The weighted [blue]`Slots` are inserted into a [blue]`PriorityQueue` and the closest matching [blue]`Slots` will be polled into the output list. + -Upon executing the `find` command with valid parameters (refer to <> for `find` usage), +Upon executing the `find` command with valid parameters, a sequence of events is executed. The sequence of events illustrated in the Sequence Diagram below will be in reference to the execution of a `find n/keyword` command. The sequence of events are as follows: diff --git a/src/planmysem/common/Messages.java b/src/planmysem/common/Messages.java index 07a10adfa..5a9270853 100644 --- a/src/planmysem/common/Messages.java +++ b/src/planmysem/common/Messages.java @@ -108,7 +108,7 @@ public static String craftListMessageWeighted(List tries) { sb.append("\n"); count++; } - sb.append("\n To view more information about the slot, try the 'view day' command!"); + sb.append("\n To view more information about a particular slot, try the 'view day' command!"); return sb.toString(); } @@ -138,7 +138,7 @@ public static String craftListMessage(List tags = slotBuilder.generateSlot(1).getTags(); String tagToTest = tags.iterator().next(); @@ -248,7 +248,7 @@ public void execute_slotAcceptedByModel_ListTagSuccessful() throws Exception { } @Test - public void execute_slotAcceptedByModel_ListNameNotFound() throws Exception { + public void execute_slotAcceptedByModel_ListNameNotFound() { String nameToTest = slotBuilder.generateSlot(1).getName().concat("NotTheSame"); CommandResult commandResult = new ListCommand(nameToTest, null).execute(model, commandHistory); @@ -266,7 +266,7 @@ public void execute_slotAcceptedByModel_ListNameNotFound() throws Exception { } @Test - public void execute_slotAcceptedByModel_ListTagNotFound() throws Exception { + public void execute_slotAcceptedByModel_ListTagNotFound() { Set tags = slotBuilder.generateSlot(1).getTags(); String tagToTest = tags.iterator().next(); tagToTest = tagToTest.concat("NotTheSame"); @@ -289,9 +289,9 @@ public void execute_slotAcceptedByModel_ListTagNotFound() throws Exception { } @Test - public void execute_listAll() throws Exception{ + public void execute_listAll() { - CommandResult commandResult = new ListCommand("all").execute(model, commandHistory); + CommandResult commandResult = new ListCommand().execute(model, commandHistory); final List>> selectedSlots = new ArrayList<>();