Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Maybe?) Extension Inference: infer one layer at a time #918

Closed
Tracked by #426
croyzor opened this issue Apr 8, 2024 · 1 comment
Closed
Tracked by #426

(Maybe?) Extension Inference: infer one layer at a time #918

croyzor opened this issue Apr 8, 2024 · 1 comment
Assignees

Comments

@croyzor
Copy link
Contributor

croyzor commented Apr 8, 2024

Post #904, all type arguments/variables refer only to the nearest FuncDefn that contains them.

In the presence of FuncDefns which can take ExtensionSet arguments, we need to be smarter about traversing the hugr when running extension inference. For instance, an extension identifier meaning "de Bruijn index 0" has different meanings depending on the FuncDefn it is contained within.

Hence, we should run inference on each hierarchy level of the graph, feeding results forward as appropriate.

Update: MAYBE we need this for #919, but possibly we can just be smarter with generating constraints. We might need it for #640, though (or might not!).

@acl-cqc acl-cqc changed the title Extension Inference: infer one layer at a time (Maybe?) Extension Inference: infer one layer at a time Apr 10, 2024
@croyzor croyzor self-assigned this May 15, 2024
@acl-cqc
Copy link
Contributor

acl-cqc commented Oct 2, 2024

I was gonna say, obsolete since #1142 - but could also say, done by that PR, in that #1142 infers hierarchically (children before parent) anyway....

@acl-cqc acl-cqc closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants