fix: Fix printing of generic function parameters #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
commented
Oct 1, 2024
| def to_bound(self, idx: int | None = None) -> Argument: | ||
| def to_bound(self, idx: int | None = None) -> TypeArg: |
There was a problem hiding this comment.
Drive by: Use a more precise return type which is used in the test below
mark-koch
commented
Oct 1, 2024
| GuppyTypeError: Cannot instantiate non-linear type variable `T` in type `forall n, T: nat. array[T, n] -> int` with linear type `qubit` | ||
| GuppyTypeError: Cannot instantiate non-linear type variable `T` in type `forall T, n: nat. array[T, n] -> int` with linear type `qubit` |
There was a problem hiding this comment.
This was actually wrong in the golden error and no one noticed 😅
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 59 59
Lines 6170 6170
=======================================
Hits 5651 5651
Misses 519 519 ☔ View full report in Codecov by Sentry. |
croyzor
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482