Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing URL replaced by 404 URL on coding.blog-deployed site #14

Closed
TysonMN opened this issue Jun 16, 2020 · 3 comments
Closed

Missing URL replaced by 404 URL on coding.blog-deployed site #14

TysonMN opened this issue Jun 16, 2020 · 3 comments
Assignees
@must
Labels
enhancement New feature or request

Comments

@TysonMN
Copy link
Contributor

TysonMN commented Jun 16, 2020 •
edited
Loading

Going to https://coding.blog/asdf shows the 404 page but leaves the URL unchanged.
2020-06-15_23-11-55_131_chrome

Going to http://localhost:3000/asdf when locally hosting my blog shows the 404 page but leaves the URL unchanged.
2020-06-15_23-12-50_132_chrome

However, going to https://tysonwilliams.coding.blog/asdf shows the 404 page AND changes the URL to https://tysonwilliams.coding.blog/404.
2020-06-15_23-13-10_133_chrome

Why is the URL being replaced? I don't want this to happen. It makes it more difficult to debug why the 404 is happening. How can I make it so the URL is not replaced?
@TysonMN TysonMN changed the title Missing URL replaced by 404 URL on GitHub-deployed page Missing URL replaced by 404 URL on GitHub-deployed site Jun 16, 2020
@loreanvictor loreanvictor added the enhancement New feature or request label Jun 16, 2020
@TysonMN TysonMN changed the title Missing URL replaced by 404 URL on GitHub-deployed site Missing URL replaced by 404 URL on coding.blog-deployed site Jun 16, 2020
@TysonMN TysonMN mentioned this issue Jun 16, 2020
Closed
@must
Copy link
Member

must commented Oct 14, 2020

Due to the current way we handle CDN requests, it was implemented based on a redirect. I will look into how we can improve it towards having no redirects but rather a 404 response with the proper not found html page.

@TysonMN
Copy link
Contributor Author

TysonMN commented Oct 14, 2020 •
edited
Loading

And do you understand why coding.blog and tysonwilliams.coding.blog behave differently?

@must
Copy link
Member

must commented Oct 14, 2020

@TysonMN Yes, Coding.blog is handled through Github Pages which already provides this behaviour as you want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@must must

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@must @loreanvictor @TysonMN