Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure yeast gem works nicely #9

Merged
merged 1 commit into from
Aug 19, 2024
Merged

make sure yeast gem works nicely #9

merged 1 commit into from
Aug 19, 2024

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Aug 19, 2024

...esp the compartments and NaNs in charges

Closes #8

...esp the compartments and NaNs in charges
@exaexa exaexa requested a review from stelmo August 19, 2024 14:17
@exaexa
Copy link
Member Author

exaexa commented Aug 19, 2024

also btw I decided that we just stabilize this on 1.0 so that we can add features without breaking everyone's stuff

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ea240cc) to head (c1bcc40).

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          163       180   +17     
=========================================
+ Hits           163       180   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa exaexa merged commit 611fd0f into master Aug 19, 2024
3 checks passed
@exaexa exaexa deleted the mk-fix-yeast-gem branch August 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAT model not converting to CanonicalModel
3 participants