Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for AbstractFBCModels to 0.3, (keep existing compat) #7

Merged

Conversation

github-actions[bot]
Copy link

This pull request changes the compat entry for the AbstractFBCModels package from 0.1, 0.2 to 0.1, 0.2, 0.3.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@exaexa exaexa force-pushed the compathelper/new_version/2024-06-10-12-48-43-523-00499766618 branch from 0437ef0 to 352432c Compare June 10, 2024 13:31
@exaexa exaexa force-pushed the compathelper/new_version/2024-06-10-12-48-43-523-00499766618 branch from 521a764 to 9cdbb11 Compare June 10, 2024 14:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b8f9629) to head (89db32f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           88       163   +75     
=========================================
+ Hits            88       163   +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa exaexa marked this pull request as draft June 10, 2024 14:40
@exaexa exaexa force-pushed the compathelper/new_version/2024-06-10-12-48-43-523-00499766618 branch from 54d14e2 to 3d47115 Compare June 10, 2024 18:21
@exaexa exaexa force-pushed the compathelper/new_version/2024-06-10-12-48-43-523-00499766618 branch 6 times, most recently from ad9c301 to a9ba498 Compare June 10, 2024 19:13
@exaexa exaexa force-pushed the compathelper/new_version/2024-06-10-12-48-43-523-00499766618 branch from a9ba498 to a670d28 Compare June 10, 2024 19:16
@exaexa exaexa marked this pull request as ready for review June 10, 2024 19:20
@exaexa exaexa requested a review from stelmo June 10, 2024 19:20
@exaexa
Copy link
Member

exaexa commented Jun 10, 2024

@stelmo I added a bit more stuff here. We can release after this.

@exaexa exaexa marked this pull request as draft June 10, 2024 19:41
@exaexa
Copy link
Member

exaexa commented Jun 10, 2024

(still needs test coverage)

@exaexa
Copy link
Member

exaexa commented Jun 11, 2024

(still needs the coverage of the weird cases)

@exaexa exaexa self-assigned this Jun 11, 2024
Copy link
Member

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I will add tests if not 100%

@exaexa exaexa marked this pull request as ready for review June 13, 2024 07:04
@exaexa exaexa merged commit ea240cc into master Jun 13, 2024
3 checks passed
@exaexa exaexa deleted the compathelper/new_version/2024-06-10-12-48-43-523-00499766618 branch June 13, 2024 07:05
@exaexa exaexa mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants