-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for AbstractFBCModels to 0.3, (keep existing compat) #7
CompatHelper: bump compat for AbstractFBCModels to 0.3, (keep existing compat) #7
Conversation
0437ef0
to
352432c
Compare
521a764
to
9cdbb11
Compare
this is written in luxembourg, no space for more space
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 88 163 +75
=========================================
+ Hits 88 163 +75 ☔ View full report in Codecov by Sentry. |
54d14e2
to
3d47115
Compare
ad9c301
to
a9ba498
Compare
a9ba498
to
a670d28
Compare
@stelmo I added a bit more stuff here. We can release after this. |
(still needs test coverage) |
(still needs the coverage of the weird cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I will add tests if not 100%
This pull request changes the compat entry for the
AbstractFBCModels
package from0.1, 0.2
to0.1, 0.2, 0.3
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.