Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an explicit warning about what happens if people gapfill pseudoreactions #80

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Nov 22, 2024

Thanks to @oxinabox for highlighting the issue

Closes #78

…actions

Thanks to @oxinabox for highlighting the issue

Closes #78
@exaexa exaexa requested a review from stelmo November 22, 2024 13:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9e4be24) to head (89461ba).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          584       584           
=========================================
  Hits           584       584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to include example code for identifying such reactions in your universal model?
OTOH automated cleaning PR is coming so maybe can wait for that

@exaexa
Copy link
Member Author

exaexa commented Nov 27, 2024

@oxinabox yes that's the topic for #81. Thanks!

@exaexa exaexa merged commit ed2e260 into master Nov 27, 2024
4 checks passed
@exaexa exaexa deleted the mk-mind-the-gap branch November 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gap filling produces nonempty result when filling a model that is already feasible
3 participants