-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show load and file_extensions in accessors #27
Conversation
OK actually to keep people from getting confused, could we make the EDIT: maybe even Other than that this looks wunderbar, thanks again! PS I see you rebased, perfect. :D |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 267 280 +13
=========================================
+ Hits 267 280 +13 ☔ View full report in Codecov by Sentry. |
I think it is pretty clear from how it is printed: julia> AbstractFBCModels.required_accessors()
[1] reactions(a::AbstractFBCModels.AbstractFBCModel) @ AbstractFBCModels none:0
[2] n_reactions(a::AbstractFBCModels.AbstractFBCModel) @ AbstractFBCModels none:0
[3] metabolites(a::AbstractFBCModels.AbstractFBCModel) @ AbstractFBCModels none:0
...
[11] save(a::AbstractFBCModels.AbstractFBCModel, path::String) @ AbstractFBCModels none:0
[12] load(::Type{A}, path::String) where A<:AbstractFBCModel @ AbstractFBCModels ~/repos/AbstractFBCModels.jl/src/io.jl:7
[13] filename_extensions(::Type{A}) where A<:AbstractFBCModel @ AbstractFBCModels ~/repos/AbstractFBCModels.jl/src/io.jl:25 but up to you. |
actually yeah with the types it looks completely transparent. Thanks a lot! |
Like #26 this seemed an interesting intellectual exercise.
This functionality looks scary and technically it is internals.
But I have been using it in ExprTools.jl in like every version of julia back til 1.0
Having to use an internal method for this is another manifestation of JuliaLang/julia#20555
I put this in a helper function so that after #26 we could add it to that list also