Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Code in public/src/admin/extend/widgets.js #589

Closed

Conversation

dhanya-cmu
Copy link

This PR resolves #554, with the following sonar cloud warning: https://sonarcloud.io/project/issues?open=AZHAkAeb1341_VbvRHcj&id=dhanya-cmu_NodeBB

The code was refactored to not nest functions more than 4 levels deep. This was done by splitting up the problematic function and moving it outside the body of a main function.

Copy link

sonarcloud bot commented Sep 6, 2024

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10731779410

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

@dhanya-cmu dhanya-cmu closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring code in public/src/admin/extend/widgets.js
2 participants